----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28069/#review61603 -----------------------------------------------------------
Bad patch! Reviews applied: [28063, 28065, 28069] Failed command: ./support/apply-review.sh -n -r 28069 Error: 2014-11-15 01:55:34 URL:https://reviews.apache.org/r/28069/diff/raw/ [20361/20361] -> "28069.patch" [1] error: patch failed: src/slave/constants.hpp:40 error: src/slave/constants.hpp: patch does not apply error: patch failed: src/slave/constants.cpp:29 error: src/slave/constants.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 15, 2014, 1:24 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28069/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 1:24 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor via CommandInfo and an environment variable. > Shutdown timeout in ExecutorProcess and signal escalation timeout in > CommandExecutor are now dependent on this value. > > > Diffs > ----- > > src/exec/exec.cpp e15f834beda94664b8e95c49ea87b4d36b853e71 > src/launcher/executor.cpp cbc8750a4d182251e6c15da6c7e75443d8c110bb > src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec > src/slave/constants.cpp 2a99b1105af0e2d62b956fa96988f477937a46bd > src/slave/containerizer/containerizer.cpp > f234835180b42331f731d92cd2ad7bd56b6efa70 > src/slave/flags.hpp fee79e04cca14e136241af06af1fa9105a70b6dd > src/slave/slave.cpp 275081cd1b09850c20325c3f1535f8462c7e7982 > src/tests/gc_tests.cpp 8618ae12b337bea19a82dec52455cd19cc735d89 > src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec > > Diff: https://reviews.apache.org/r/28069/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
