----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28069/#review61717 -----------------------------------------------------------
Patch looks great! Reviews applied: [28065, 28063, 28069] All tests passed. - Mesos ReviewBot On Nov. 17, 2014, 12:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28069/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 12:14 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor via CommandInfo and an environment variable. > Shutdown timeout in ExecutorProcess and signal escalation timeout in > CommandExecutor are now dependent on this value. > > > Diffs > ----- > > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp 6175bf5 > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/containerizer/containerizer.cpp f234835 > src/slave/flags.hpp fee79e0 > src/slave/slave.cpp 06b2e18 > src/tests/gc_tests.cpp 8618ae1 > src/tests/slave_tests.cpp 18ff8fe > > Diff: https://reviews.apache.org/r/28069/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
