> On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > Looking good! Some comments below
Thank you for the thorough review, Niklas! > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/exec/exec.cpp, line 58 > > <https://reviews.apache.org/r/28069/diff/2/?file=765858#file765858line58> > > > > s/grace_shutdown/graceful_shutdown/g? See my comment on consistency in r28065. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/exec/exec.cpp, line 729 > > <https://reviews.apache.org/r/28069/diff/2/?file=765858#file765858line729> > > > > Still don't like the notion of 'adjusting'. You get _another_ kind of > > timeout from the first value (which describes the global and inner-most > > timeout). > > > > Can we change it? Sure. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/launcher/executor.cpp, line 59 > > <https://reviews.apache.org/r/28069/diff/2/?file=765859#file765859line59> > > > > Same here - graceful_shutdown.hpp? See above. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/launcher/executor.cpp, line 81 > > <https://reviews.apache.org/r/28069/diff/2/?file=765859#file765859line81> > > > > We switch between escalationTimeout and shutdownTimeout. We should be > > consistent. Makes sense. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/launcher/executor.cpp, lines 433-435 > > <https://reviews.apache.org/r/28069/diff/2/?file=765859#file765859line433> > > > > Which is a problem in case of pid reuse? Worth mentioning here? Sure. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/launcher/executor.cpp, lines 687-690 > > <https://reviews.apache.org/r/28069/diff/2/?file=765859#file765859line687> > > > > Can you remind me again why you needed to move this? So that we first read ENV vars and then cmd params. > On Nov. 20, 2014, 8:39 p.m., Niklas Nielsen wrote: > > src/tests/slave_tests.cpp, lines 1407-1408 > > <https://reviews.apache.org/r/28069/diff/2/?file=765866#file765866line1407> > > > > Please align like we do here: > > https://github.com/apache/mesos/blob/master/src/tests/slave_tests.cpp#L803 > > > > Here and below. I would argue that this approach is more readable. Since it's expicitly allowed by #3 of our C++ style guide, I would prefer to keep it as it is. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28069/#review62277 ----------------------------------------------------------- On Nov. 17, 2014, 12:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28069/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 12:14 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor via CommandInfo and an environment variable. > Shutdown timeout in ExecutorProcess and signal escalation timeout in > CommandExecutor are now dependent on this value. > > > Diffs > ----- > > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp 6175bf5 > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/containerizer/containerizer.cpp f234835 > src/slave/flags.hpp fee79e0 > src/slave/slave.cpp 06b2e18 > src/tests/gc_tests.cpp 8618ae1 > src/tests/slave_tests.cpp 18ff8fe > > Diff: https://reviews.apache.org/r/28069/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
