----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27550/#review62016 -----------------------------------------------------------
Looks good. Just a few questions include/mesos/mesos.proto <https://reviews.apache.org/r/27550/#comment103938> Unique per role: Does this mean that a multi-role framework cannot change which role its persistent volume is associated with? Unique per slave: Wouldn't it be nice if you could (e.g. during a maintenance period) migrate a volume to another slave and use it there? include/mesos/mesos.proto <https://reviews.apache.org/r/27550/#comment103939> What if host_path is set? Is it ignored (for now)? Or does it actually mean something? include/mesos/mesos.proto <https://reviews.apache.org/r/27550/#comment103940> Does this necessarily describe a 'disk'? Or should it more generically be called "storage" in the future? - Adam B On Nov. 18, 2014, 12:05 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27550/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:05 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > > Diff: https://reviews.apache.org/r/27550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
