> On Nov. 18, 2014, 11:55 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 403 > > <https://reviews.apache.org/r/27550/diff/3/?file=767713#file767713line403> > > > > I'm kind of going back and forth about whether or not we should have a > > Persistence nested protobuf message. At first I was thinking no, but now > > I'm thinking that we might want to specify other things. For example, maybe > > we want to introduce a way to persist this for some duration but no longer. > > Who knows, but maybe it's better to just have it behind the Persistence > > message that you originally had. > > Vinod Kone wrote: > +1. That way a release call can take Persistence protobuf too.
Per Vinod's comment, if we want to do that, does that mean that we need to make Persistence or DiskInfo top level (i.e., like Volume)? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27550/#review62056 ----------------------------------------------------------- On Nov. 18, 2014, 8:05 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27550/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 8:05 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > > Diff: https://reviews.apache.org/r/27550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
