----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63015 -----------------------------------------------------------
3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105188> Please throw in a comment on each test. For example here, it's not clear what code paths or scenarios that you want to cover. Also, I think we usually capitalize the test name. Can you do a scan for that? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105201> Comment style non-// and inlined. Can you move this on it's own line? Here and below 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105192> spell out buffer. Also, how about hoisting the constant into a const int? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105196> This defaults to? Localhost? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105200> We pass it in here and overwrite it later - what's going on? :-) 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105197> What does the constant mean here? Maybe create a const int 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105199> Can you use the Socket.connect() call? If not, why? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105202> std::string and use .size()/.length() instead of hardcoding the lenght? Here and below 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105204> The buffer namings are a bit inconsistent. Can we settle on 'buffer' or at least a full word? Can you do a scan for that? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105203> How about using mktemp? Take a look at how we write (and clean up) after temporary files in the other tests. 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105205> Why +2? 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105206> Why +1? - Niklas Nielsen On Nov. 24, 2014, 2:15 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28415/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 2:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2119 > https://issues.apache.org/jira/browse/MESOS-2119 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28415/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
