----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63180 -----------------------------------------------------------
3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105362> Swap 's' and 0 arguments please. 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105360> Swap 'errno' and EBADF please. 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105363> Can you make a quick pass and swap the arguments so that it's: ASSERT|EXPECT_*(expected, actual); Thanks! 3rdparty/libprocess/src/tests/socket_tests.cpp <https://reviews.apache.org/r/28415/#comment105361> s/c api/C API/ - Benjamin Hindman On Nov. 26, 2014, 10:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28415/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2119 > https://issues.apache.org/jira/browse/MESOS-2119 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28415/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
