> On Nov. 25, 2014, 7:06 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/socket_tests.cpp, line 79 > > <https://reviews.apache.org/r/28415/diff/1/?file=774765#file774765line79> > > > > This defaults to? Localhost?
Added an overload for bind in r28485 that makes this pattern more clear. > On Nov. 25, 2014, 7:06 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/tests/socket_tests.cpp, line 81 > > <https://reviews.apache.org/r/28415/diff/1/?file=774765#file774765line81> > > > > We pass it in here and overwrite it later - what's going on? :-) Added an overload for bind in r28485 that makes this pattern more clear. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/#review63015 ----------------------------------------------------------- On Nov. 26, 2014, 10:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28415/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2119 > https://issues.apache.org/jira/browse/MESOS-2119 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28415/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
