----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/#review63713 -----------------------------------------------------------
Ship it! One general comment; introducing the event manager abstraction should IMHO be supported by a jira ticket which captures the new api. 3rdparty/libprocess/src/clock.cpp <https://reviews.apache.org/r/28315/#comment105992> Don't we want to do a scan for libev references and generalize them? 3rdparty/libprocess/src/event_loop.hpp <https://reviews.apache.org/r/28315/#comment105991> Why the void pointer argument? 3rdparty/libprocess/src/libev.cpp <https://reviews.apache.org/r/28315/#comment105990> Is this relevant? We are not testing on opensolaris and last time I did (end last year) it didn't work. 3rdparty/libprocess/src/libev.cpp <https://reviews.apache.org/r/28315/#comment105988> 0.? I know it is just moved code, but it would be nice to move the 2100000.0 value into a constant which gave a bit more context to what it does. - Niklas Nielsen On Dec. 3, 2014, 11:09 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28315/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:09 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/clock.cpp dfe9ced2415b8567abb8c137ab73d90b59164d67 > 3rdparty/libprocess/src/event_loop.hpp PRE-CREATION > 3rdparty/libprocess/src/libev.cpp 8a557ce1d604f27fc1cc2ce601f1fc94f49d1ae6 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28315/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
