----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/#review63862 -----------------------------------------------------------
3rdparty/libprocess/src/clock.cpp <https://reviews.apache.org/r/28315/#comment106173> Is this just a forward declaration? Let's comment as much please. 3rdparty/libprocess/src/clock.cpp <https://reviews.apache.org/r/28315/#comment106192> s/eventloop/event loop/ everywhere in comments please! 3rdparty/libprocess/src/libev.cpp <https://reviews.apache.org/r/28315/#comment106191> I was thinking that anyone could call this in order to get a delayed function, but with this implementation if two threads call this at the same time only the last function will execute. How about creating an ev_timer for each one? Also, how about using run_in_event_loop instead of an explicit ev_async_send? 3rdparty/libprocess/src/libev.cpp <https://reviews.apache.org/r/28315/#comment106180> s/void */void* / - Benjamin Hindman On Dec. 3, 2014, 11:18 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28315/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2168 > https://issues.apache.org/jira/browse/MESOS-2168 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/clock.cpp dfe9ced2415b8567abb8c137ab73d90b59164d67 > 3rdparty/libprocess/src/event_loop.hpp PRE-CREATION > 3rdparty/libprocess/src/libev.cpp 8a557ce1d604f27fc1cc2ce601f1fc94f49d1ae6 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28315/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
