----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/#review68279 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29895/#comment112454> will this be broken down by volume eventually? or by path? src/slave/containerizer/isolators/posix/disk.hpp <https://reviews.apache.org/r/29895/#comment112457> s/cached/cached_usage/ or recorded_usage src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/29895/#comment112455> this is an odd use for an owned pointer. you should 'get' a raw pointer to indicate that you're not taking ownership. src/tests/disk_quota_tests.cpp <https://reviews.apache.org/r/29895/#comment112458> is there a way to test the disk usage without spinning up a master, slave, etc? ie, can we just spin up an isolator process that points at a given path and check it? the test would be faster to run and more focused. - Dominic Hamon On Jan. 14, 2015, 12:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29895/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 12:30 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added disk usage statistics reporting. This allow the isolator to report > resource statistics for disk (sandbox). > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 > src/slave/containerizer/isolators/posix/disk.hpp PRE-CREATION > src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29895/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
