> On Jan. 16, 2015, 12:52 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.hpp, lines 114-118 > > <https://reviews.apache.org/r/29895/diff/1/?file=821625#file821625line114> > > > > At this point, is it worth having single map with a struct capturing > > these values? > > > > e.g. > > > > ``` > > struct QuotaInfo > > { > > Resources quota; > > Future<Bytes> usage; > > Option<Bytes> lastUsage; > > }; > > > > hashmap<std::string, QuotaInfo> quotas > > ``` > > > > It looks a bit tricky to keep all of these maps in sync.
I use PathInfo and hashmap<string, PathInfo> paths. Essentially, quota/usage/lastUsage are information about the path we are checking. > On Jan. 16, 2015, 12:52 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 207 > > <https://reviews.apache.org/r/29895/diff/1/?file=821626#file821626line207> > > > > This doesn't check the third map? This is not needed anymore. > On Jan. 16, 2015, 12:52 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 288 > > <https://reviews.apache.org/r/29895/diff/1/?file=821626#file821626line288> > > > > ``` > > // NOTE: There may be a large delay (# of containers * interval) > > // until an initial cached value is returned here! > > if (!info->cached.contains(info->directory)) { > > ... > > } > > ``` Added. > On Jan. 16, 2015, 12:52 a.m., Ben Mahler wrote: > > src/tests/disk_quota_tests.cpp, line 211 > > <https://reviews.apache.org/r/29895/diff/1/?file=821627#file821627line211> > > > > // NOTE: We can't pause the clock because we need the reaper to reap > > the 'du' subprocess. Added. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/#review68342 ----------------------------------------------------------- On Jan. 14, 2015, 8:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29895/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 8:30 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added disk usage statistics reporting. This allow the isolator to report > resource statistics for disk (sandbox). > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 > src/slave/containerizer/isolators/posix/disk.hpp PRE-CREATION > src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29895/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
