----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/#review68511 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/29895/#comment112806> Do you want some sanity CHECKs here? ``` Option<Bytes> quota = info->paths[info->directory].quota.disk(); CHECK_SOME(quota); result.set_disk_limit_bytes(quota.get().bytes()); ``` - Ben Mahler On Jan. 16, 2015, 11:52 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29895/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:52 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added disk usage statistics reporting. This allow the isolator to report > resource statistics for disk (sandbox). > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 > src/slave/containerizer/isolators/posix/disk.hpp > a32b0e7c231b47bb07be4e884f8d038a9ceae145 > src/slave/containerizer/isolators/posix/disk.cpp > fcadd780f9d417f7422080a03cfbfc2e4d15f1b3 > src/tests/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e > > Diff: https://reviews.apache.org/r/29895/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
