----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review70052 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/29883/#comment115008> returning a JSON array as a response is probably surprising. I'd expect the top-level object returned to be an object (ie, dict). ie: { 'slaves': [.. slaves here..] } rather than just the array. there's no standard per se, but it seems to be the Done Thing [tm]. src/master/master.cpp <https://reviews.apache.org/r/29883/#comment115009> +1 - Dominic Hamon On Jan. 16, 2015, 5:37 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29883/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 5:37 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos-git > > > Description > ------- > > Adds endpoints for paths /master/slaves and > /master/frameworks/{framework}/tasks/{task} > > Builds on the abandoned patch 14286. > > Old description: this is WIP that bmahler wants to take on. > > > Diffs > ----- > > src/master/http.cpp 46890be > src/master/master.hpp 26116af > src/master/master.cpp 63ca19a > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/29883/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
