> On Feb. 5, 2015, 2:40 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 613-615 > > <https://reviews.apache.org/r/29883/diff/5/?file=847364#file847364line613> > > > > Shouldn't it be /slaves.json? If yes, please correct in other places as > > well.
So this was discussed this with nnielsen and at the end it boils down to, in REST like endpoints, is not commong to have something like `/frameworks.json/UUID/tasks.json/UUID`. Marathon also has the endpoints: `/v2/apps/` and `/v2/apps/UUID/` which are not suffixed with json. This enpoint can be extended in the future to something like `/master/slaves/<UUID>/foobar` > On Feb. 5, 2015, 2:40 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 382 > > <https://reviews.apache.org/r/29883/diff/5/?file=847362#file847362line382> > > > > Can there be any security issues with exposing slave's PID? Any reason > > we want to expose it? Let's see what someone else things about it. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71205 ----------------------------------------------------------- On Feb. 4, 2015, 11:37 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29883/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 11:37 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/slaves. > > Works in conjunction with [30612](https://reviews.apache.org/r/30612). > > Builds on the abandoned patch 14286. > > Old description: this is WIP that bmahler wants to take on. > > > Diffs > ----- > > src/master/http.cpp 3981b18 > src/master/master.hpp 337e00a > src/master/master.cpp 1005686 > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/29883/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
