----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71205 -----------------------------------------------------------
Clean and brief, I like it! Some thoughts below. src/master/http.cpp <https://reviews.apache.org/r/29883/#comment116878> Can there be any security issues with exposing slave's PID? Any reason we want to expose it? src/master/master.cpp <https://reviews.apache.org/r/29883/#comment116879> Shouldn't it be /slaves.json? If yes, please correct in other places as well. - Alexander Rukletsov On Feb. 4, 2015, 10:37 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29883/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 10:37 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/slaves. > > Works in conjunction with [30612](https://reviews.apache.org/r/30612). > > Builds on the abandoned patch 14286. > > Old description: this is WIP that bmahler wants to take on. > > > Diffs > ----- > > src/master/http.cpp 3981b18 > src/master/master.hpp 337e00a > src/master/master.cpp 1005686 > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/29883/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
