----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review70774 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/30546/#comment116193> why are these doubles? src/slave/containerizer/isolators/cgroups/mem.hpp <https://reviews.apache.org/r/30546/#comment116194> should you check for overflow? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment116195> no more using namespace please. it pollutes the global namespace. see the style guide. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment116196> delete this src/tests/isolator_tests.cpp <https://reviews.apache.org/r/30546/#comment116197> s/> >/>>/ src/tests/isolator_tests.cpp <https://reviews.apache.org/r/30546/#comment116198> this is not a good enough test. you should be testing for specific expectations and testing more than just one counter. - Dominic Hamon On Feb. 2, 2015, 9:29 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 9:29 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto 26003fada2e4c4be0e9ebc4663f7ebab858cc48d > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/mem.cpp > 711d66d7771cac13be831d73af3ef570d6785473 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
