----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review70822 -----------------------------------------------------------
src/authentication/authenticator.hpp <https://reviews.apache.org/r/27760/#comment116260> Not looking at the implementation, this seems to be a weird interface method. if authenticate() returns a future why do the caller need an explicit terminate() to terminate the authentication? would be easy if he can just 'discard' the future which will cause termination. src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/27760/#comment116268> Instead of terminate() (or making it public) why not have an onDiscard handler on the future returned at #508 that erases the pid? src/master/master.cpp <https://reviews.apache.org/r/27760/#comment116269> Can this be authenticating[pid].discard() ? src/master/master.cpp <https://reviews.apache.org/r/27760/#comment116270> ditto. - Vinod Kone On Feb. 3, 2015, 11:05 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 11:05 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp d739a02 > src/authentication/cram_md5/auxprop.hpp b894386 > src/authentication/cram_md5/auxprop.cpp cf503a2 > src/master/master.hpp 337e00a > src/master/master.cpp 1005686 > src/tests/cram_md5_authentication_tests.cpp a356aa1 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
