-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
-----------------------------------------------------------

(Updated Feb. 18, 2015, 3:57 a.m.)


Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.


Changes
-------

Addressed all of Adam's recent comments.


Bugs: MESOS-2050
    https://issues.apache.org/jira/browse/MESOS-2050


Repository: mesos


Description
-------

The initial design and implementation of the authenticator module interface 
caused issues and was not optimal for heavy lifting setup of external 
dependencies. By introducing a two fold design, this has been decoupled from 
the authentication message processing. The new design also gets us back on 
track to the goal of makeing SASL a soft dependency of mesos.


Diffs (updated)
-----

  include/mesos/authentication/authenticator.hpp f66217a 
  src/Makefile.am d372404 
  src/authentication/cram_md5/authenticator.hpp 7578ea1 
  src/authentication/cram_md5/authenticator.cpp PRE-CREATION 
  src/authentication/cram_md5/auxprop.hpp d036b11 
  src/authentication/cram_md5/auxprop.cpp 5ff9755 
  src/master/master.hpp 6a39df0 
  src/master/master.cpp f10a3cf 
  src/tests/cram_md5_authentication_tests.cpp dd102dc 

Diff: https://reviews.apache.org/r/27760/diff/


Testing
-------

make check


Thanks,

Till Toenshoff

Reply via email to