----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72109 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/containerizer.hpp <https://reviews.apache.org/r/30906/#comment118054> We'll likely be adding more metrics so what about moving the ctor and dtor definitions to the cpp file, this matches the style in the port_mapping isolator too. - Ian Downes On Feb. 11, 2015, 5:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 5:34 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 074a2d82dcd882e52f8cd62ed7493295596acb26 > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > No existing launcher tests to inject metrics test. Will work with @idownes to > figure how to write one. > > > Thanks, > > Vinod Kone > >
