> On Feb. 12, 2015, 5:41 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 280 > > <https://reviews.apache.org/r/30906/diff/1/?file=861366#file861366line280> > > > > Should this just be "mesos_containerizer/launcher_destroy_errors"? > > Looking at our port_mapping/ metrics, and other subcomponent metrics, that > > seems like a more consistent name? > > Ben Mahler wrote: > Or, is it possible to have this error in the launcher and just call it: > "launcher/destroy_errors" or "linux_launcher/destroy_errors"? > > Jie Yu wrote: > Or we can modify port_mapping metrics to be > `slave/containerizer/mesos/isolators/network/port_mapping/xxx`. Maybe that's > too long?
i like the hierarchical model for subcomponent metrics because it's easier to grasp, esp., when multiple subcomponents can exist at the same time (e.g., mesos can have multiple containerizers at run time). i wish port mapping metrics followed similar model. if isolators would only ever be used with mesos containerizer we could maybe just use "isolators/network/port_mapping/xxxx". having said that, making this a linux launcher metric sgtm. moved it to linux launcher and named it "launcher/linux/destroy_errors" - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72190 ----------------------------------------------------------- On Feb. 12, 2015, 8:07 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 8:07 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > 37304222323d3089b95df605d2077a3f88d11277 > src/slave/containerizer/linux_launcher.cpp > 3fdfb5709d48d079bbe904a91b773f131131b08d > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > No existing launcher tests to inject metrics test. Will work with @idownes to > figure how to write one. > > > Thanks, > > Vinod Kone > >
