> On Feb. 12, 2015, 8:22 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 953 > > <https://reviews.apache.org/r/30906/diff/1/?file=861367#file861367line953> > > > > Can you also add it to the docker containerizer?
docker containerizer doesn't have a launcher. note that this metric only captures launcher destroy errors, not all types of destroy errors, because we have seen a specific need for it. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72125 ----------------------------------------------------------- On Feb. 12, 2015, 8:07 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 8:07 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > 37304222323d3089b95df605d2077a3f88d11277 > src/slave/containerizer/linux_launcher.cpp > 3fdfb5709d48d079bbe904a91b773f131131b08d > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > No existing launcher tests to inject metrics test. Will work with @idownes to > figure how to write one. > > > Thanks, > > Vinod Kone > >
