-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30911/#review72362
-----------------------------------------------------------
Let's create a special test case for filters. It looks like following test
cases are uncovered (or I haven't noticed them in the code):
1. `Resources::Filter::unreserved()` and `Resources::Filter::reserved("*")` are
essentially the same.
2. `Resources::Filter::any()` does what it should.
3. `Resources::Filter(predicate)` filters resources according to the given
predicate.
include/mesos/resources.hpp
<https://reviews.apache.org/r/30911/#comment118445>
Does it make sense to provide `static Filter predicate(const Predicate& p)`
for consistency and make this c-tor private?
src/common/resources.cpp
<https://reviews.apache.org/r/30911/#comment118443>
I'm not sure we can use `initializer_list`. Have we dropped the support for
archaic gcc already?
- Alexander Rukletsov
On Feb. 12, 2015, 2:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30911/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 2:42 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and
> Vinod Kone.
>
>
> Bugs: MESOS-2348
> https://issues.apache.org/jira/browse/MESOS-2348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
> src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
> src/master/hierarchical_allocator_process.hpp
> 10fa6ec4116174f0fa597714976507a6c54f082b
> src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52
> src/tests/hierarchical_allocator_tests.cpp
> df844b57df5f9bb886e2e380d8751c809d3fbd5b
> src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb
>
> Diff: https://reviews.apache.org/r/30911/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
