-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30911/
-----------------------------------------------------------
(Updated Feb. 14, 2015, 12:11 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and
Vinod Kone.
Changes
-------
Same approach, but a slightly different API.
1. `filter(predicate, resources)` is a non-member function to be used
seemlessly with `google::protobuf::RepeatedPtrField<Resource>`.
2. The parameter order of the `filter` function is based on the built-in
`filter` functions of languages such as Python and Haskell.
3. We'll use lambdas as a composing mechanism of predicates rather than
composing filters themselves. The caveat here is that we don't quite have
lambdas yet.
(but we'll get there!)
4. `Reserved` function object is provided as a wrapper around `isReserved`
to avoid the `lambda::bind`s since it's a widely used predicate.
Bugs: MESOS-2348
https://issues.apache.org/jira/browse/MESOS-2348
Repository: mesos
Description
-------
See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348).
Diffs (updated)
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
src/master/allocator/mesos/hierarchical.hpp
2680d6231927867d5a8d75cbc42b81d6c75fc7f2
src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52
src/master/validation.cpp acc35b25c93f2d3900d79c3070b1d681416ed66b
src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3
src/tests/hierarchical_allocator_tests.cpp
eeecfb64540b16666915074aaffaa5d506b203bc
src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb
Diff: https://reviews.apache.org/r/30911/diff/
Testing
-------
make check
Thanks,
Michael Park
