----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30911/#review73294 -----------------------------------------------------------
You may wanna do a rebase. LGTM, will give a shipit once you updated it. Thanks Mpark! include/mesos/resources.hpp <https://reviews.apache.org/r/30911/#comment119561> We don't use snake_case for function names. Please ``` s/persitent_volumes/persistentVolumes ``` src/master/allocator/mesos/hierarchical.hpp <https://reviews.apache.org/r/30911/#comment119562> Can we punt on that change right now? It does not seem to simply the code and it's actually more hard to read. src/master/master.hpp <https://reviews.apache.org/r/30911/#comment119563> s/isCheckpoint/needCheckpointing/ ? src/slave/slave.cpp <https://reviews.apache.org/r/30911/#comment119564> Can we simply the logic here to be: ``` Resources resources = task.resources(); if (task.has_executor()) { resources += task.executor().resources(); } CHECK(checkpointedResources.contains(resources.persistentVolumes()) << "..."; ``` - Jie Yu On Feb. 19, 2015, 2:54 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30911/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 2:54 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2348 > https://issues.apache.org/jira/browse/MESOS-2348 > > > Repository: mesos > > > Description > ------- > > See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348). > > > Diffs > ----- > > include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0 > src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f > src/master/allocator/mesos/hierarchical.hpp > 2680d6231927867d5a8d75cbc42b81d6c75fc7f2 > src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52 > src/master/validation.cpp acc35b25c93f2d3900d79c3070b1d681416ed66b > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/hierarchical_allocator_tests.cpp > eeecfb64540b16666915074aaffaa5d506b203bc > src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb > > Diff: https://reviews.apache.org/r/30911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
