> On Feb. 17, 2015, 11:02 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 392 > > <https://reviews.apache.org/r/30906/diff/3/?file=863791#file863791line392> > > > > You may wanna add a note here saying that we expect the lifetime of > > launcher is longer than the time it take for `ns::pid::destroy` to finish. > > Otherwise, we may delete `this` before onAny is called, leading to a > > segfault potentially. > > > > Can you double check that the above is always enforced in our code > > (especially in tests).
thanks for spotting the race! put the metric back in containerizer. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72812 ----------------------------------------------------------- On Feb. 24, 2015, 1:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 1:52 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 65cba64834d8d2224761105516c64c6ba203f9f3 > src/slave/containerizer/mesos/containerizer.hpp > d4fc8c8fdb94c470892e73ae08796b620b74d17b > src/slave/containerizer/mesos/containerizer.cpp > a587ed38b1df9ef489b4a1b5eb7f16c34d89d156 > src/tests/containerizer_tests.cpp d96a3a8955cb85c6b710c246fc23cb3aa5134920 > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
