----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72812 -----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/30906/#comment118898> You may wanna add a note here saying that we expect the lifetime of launcher is longer than the time it take for `ns::pid::destroy` to finish. Otherwise, we may delete `this` before onAny is called, leading to a segfault potentially. Can you double check that the above is always enforced in our code (especially in tests). - Jie Yu On Feb. 13, 2015, 10:37 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 10:37 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am d372404d84c9ac0bc49da7407ad366701b9586a6 > src/slave/containerizer/linux_launcher.hpp > 37304222323d3089b95df605d2077a3f88d11277 > src/slave/containerizer/linux_launcher.cpp > 3fdfb5709d48d079bbe904a91b773f131131b08d > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > src/tests/launcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
