----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/#review74416 -----------------------------------------------------------
Bad patch! Reviews applied: [31504] Failed command: ./support/apply-review.sh -n -r 31504 Error: 2015-02-27 01:01:38 URL:https://reviews.apache.org/r/31504/diff/raw/ [8303/8303] -> "31504.patch" [1] error: patch failed: src/tests/routing_tests.cpp:434 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Feb. 26, 2015, 11:15 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31504/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 11:15 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > We need a default filter which has the lowest priority and can match all > packets that are not matched by the previous filters, so that no packet will > escape (otherwise it would be dropped by fq_codel). ("default" is a key workd > in C++, therefore I choose the name "all" instead of "default".) > > > Diffs > ----- > > src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 > src/linux/routing/filter/all.hpp PRE-CREATION > src/linux/routing/filter/all.cpp PRE-CREATION > src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 > > Diff: https://reviews.apache.org/r/31504/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
