----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/#review75788 -----------------------------------------------------------
src/linux/routing/filter/basic.cpp <https://reviews.apache.org/r/31504/#comment123062> As we discussed, could you please add a 'protocol' field to basic::Classifier and expose it in the header? ``` class Classifier { public: explicit Classifier(uint16_t _protocol); uint16_t protocol() const; bool operator == (const Classifier& that) const; private: uint16_t protocol_; }; ``` - Jie Yu On March 9, 2015, 6:32 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31504/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 6:32 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > We need a default filter which has the lowest priority and can match all > packets that are not matched by the previous filters, so that no packet will > escape (otherwise it would be dropped by fq_codel). Because basic filter can > accept protocol as a parameter, the arp filter which is based on basic can > move to this as well. > > > Diffs > ----- > > src/Makefile.am 3059818 > src/linux/routing/filter/basic.hpp PRE-CREATION > src/linux/routing/filter/basic.cpp PRE-CREATION > src/linux/routing/filter/filter.hpp a603d73 > src/tests/routing_tests.cpp 59af083 > > Diff: https://reviews.apache.org/r/31504/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
