----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/#review74831 -----------------------------------------------------------
src/linux/routing/filter/all.cpp <https://reviews.apache.org/r/31504/#comment121614> I think the filter name 'all' sounds a little wiered. Also, we are duplicating a lot of the code (the code is very similar to arp filter). How about this: Let's create a basic filter which mirrors the 'basic' rtnl_cls? The basic filter Classifier takes a 'protocol' indicating what it wants to match. Drop a TODO to use the new 'basic' filter in the arp filter impl. (we can do that later). - Jie Yu On March 2, 2015, 5:21 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31504/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 5:21 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > We need a default filter which has the lowest priority and can match all > packets that are not matched by the previous filters, so that no packet will > escape (otherwise it would be dropped by fq_codel). ("default" is a key workd > in C++, therefore I choose the name "all" instead of "default".) > > > Diffs > ----- > > src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 > src/linux/routing/filter/all.hpp PRE-CREATION > src/linux/routing/filter/all.cpp PRE-CREATION > src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 > > Diff: https://reviews.apache.org/r/31504/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
