----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31677/#review75930 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp <https://reviews.apache.org/r/31677/#comment123261> I don't think we ever use this include. Please include ``` #include <stdint.h> ``` 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp <https://reviews.apache.org/r/31677/#comment123262> Can you move this comments above `namespace bits`? ``` // Provides efficient bit operations. More details can be found at: xxx ``` 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp <https://reviews.apache.org/r/31677/#comment123263> s/mask/value/ 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp <https://reviews.apache.org/r/31677/#comment123264> s/value/count/ - Jie Yu On March 10, 2015, 8:35 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31677/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 8:35 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > a5224554f6851930aa97cadc5da3d010829d87dc > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ac2bbed6fe86623fb51cac3613d79d7b1372df9d > 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 6fbbb4d1ae12b231d12a20e73c7bf6605c09d998 > 3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31677/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
