> On March 11, 2015, 7 p.m., Ben Mahler wrote: > > I'm curious, what prompted this change? > > Dominic Hamon wrote: > a comment on the original version in a review that it wasn't the best way > of counting bits. it seems like a generally useful thing to do.
another benefit: IPv6 netmasks, where there are 128 bits. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31677/#review76105 ----------------------------------------------------------- On March 10, 2015, 7:59 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31677/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 7:59 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > a5224554f6851930aa97cadc5da3d010829d87dc > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ac2bbed6fe86623fb51cac3613d79d7b1372df9d > 3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > e4e86deb8a42a1d91f4d4ac210eae26f8f57ee17 > 3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31677/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
