----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/#review76009 -----------------------------------------------------------
src/linux/routing/filter/basic.hpp <https://reviews.apache.org/r/31504/#comment123393> We wrap comment in 70 char width. Please fix here and everywhere else. src/linux/routing/filter/basic.hpp <https://reviews.apache.org/r/31504/#comment123395> Again, please use 'classid' consistently. src/linux/routing/filter/basic.cpp <https://reviews.apache.org/r/31504/#comment123401> Please expose this Classifier in the header file. src/linux/routing/filter/basic.cpp <https://reviews.apache.org/r/31504/#comment123398> Reorder these two. src/linux/routing/filter/basic.cpp <https://reviews.apache.org/r/31504/#comment123400> Oops. Shoudn't you do ``` rtnl_cls_set_protocol(cls.get(), classifier.protocol()); ``` src/linux/routing/filter/basic.cpp <https://reviews.apache.org/r/31504/#comment123402> Oops, do yo still need this check? - Jie Yu On March 10, 2015, 11:27 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31504/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 11:27 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > We need a default filter which has the lowest priority and can match all > packets that are not matched by the previous filters, so that no packet will > escape (otherwise it would be dropped by fq_codel). Because basic filter can > accept protocol as a parameter, the arp filter which is based on basic can > move to this as well. > > > Diffs > ----- > > src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 > src/linux/routing/filter/basic.hpp PRE-CREATION > src/linux/routing/filter/basic.cpp PRE-CREATION > src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba > > Diff: https://reviews.apache.org/r/31504/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
