----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review77654 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment125799> Why do you need to await(list<>) here? listener->counter() .then( ... ) src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment125798> Return an unpopulated ResourceStatistics here, rather than whatever is in result. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment125801> s/OOM events/memory pressure events/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment125802> Add a comment on what this is for, i.e., verifying dd. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment125850> s/supporting/compatible? src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment125803> do you require this to be unset? src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment125804> This path is where...? You should write into the task's sandbox path rather than the test's src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment125805> overwrite a 512 MB file repeatedly - Ian Downes On March 18, 2015, 11:32 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 11:32 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto ec8efaec13f54a56d82411f6cdbdb8ad8b103748 > src/slave/containerizer/isolators/cgroups/mem.hpp > a00f723de61b9bccd76a2948b6d14fde7a993a8d > src/slave/containerizer/isolators/cgroups/mem.cpp > 6299ca4ba01b65daa3d75c64150e2738e32b841e > src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1 > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
