----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review76642 -----------------------------------------------------------
src/authentication/cram_md5/authenticator.cpp <https://reviews.apache.org/r/27760/#comment124231> log the pid. src/authentication/cram_md5/authenticator.cpp <https://reviews.apache.org/r/27760/#comment124232> No need to include the 'pid' in the failure because the caller already knows about the pid. src/authentication/cram_md5/authenticator.cpp <https://reviews.apache.org/r/27760/#comment124230> log the pid. src/authentication/cram_md5/authenticator.cpp <https://reviews.apache.org/r/27760/#comment124227> indentation? src/authentication/cram_md5/authenticator.cpp <https://reviews.apache.org/r/27760/#comment124238> Why is this an initialization error? The previous semantics are that if credentials were not provided, authentication was simply refused. Now because of this change, we are sending an AuthenticationErrorMessage in Master::authenticate(). src/master/master.cpp <https://reviews.apache.org/r/27760/#comment124240> see my comments in CramMD5Authenticator::initialize(). No credentials didn't lead to AuthenticationErrorMessage before but rather refusal of authentication. - Vinod Kone On March 12, 2015, 12:32 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 12:32 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > include/mesos/authentication/authenticator.hpp f66217a > src/authentication/cram_md5/authenticator.hpp c6f465f > src/authentication/cram_md5/authenticator.cpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp b894386 > src/master/master.hpp 3c957ab > src/master/master.cpp dccd7c6 > src/tests/cram_md5_authentication_tests.cpp 92a89c5 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
