> On March 16, 2015, 9:41 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, lines 552-554 > > <https://reviews.apache.org/r/27760/diff/24/?file=891848#file891848line552> > > > > Why is this an initialization error? The previous semantics are that if > > credentials were not provided, authentication was simply refused. Now > > because of this change, we are sending an AuthenticationErrorMessage in > > Master::authenticate().
Yes, thanks for pointing this out. > On March 16, 2015, 9:41 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3844-3845 > > <https://reviews.apache.org/r/27760/diff/24/?file=891851#file891851line3844> > > > > see my comments in CramMD5Authenticator::initialize(). No credentials > > didn't lead to AuthenticationErrorMessage before but rather refusal of > > authentication. I am now adding a warning log into the authenticator to make sure the user gets a hint on that; ``` LOG(WARNING) << "No credentials provided, authentication requests will be " << "refused."; ``` - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review76642 ----------------------------------------------------------- On March 12, 2015, 12:32 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 12:32 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > include/mesos/authentication/authenticator.hpp f66217a > src/authentication/cram_md5/authenticator.hpp c6f465f > src/authentication/cram_md5/authenticator.cpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp b894386 > src/master/master.hpp 3c957ab > src/master/master.cpp dccd7c6 > src/tests/cram_md5_authentication_tests.cpp 92a89c5 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
