> On March 11, 2015, 9:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3858-3861 > > <https://reviews.apache.org/r/27760/diff/23/?file=890575#file890575line3858> > > > > Send a FrameworkError message (instead of AuthenticationError) here to > > avoid retries? > > Till Toenshoff wrote: > The `AuthenticationErrorMessage` is sent to the AuthenticateeProcess, not > the process to be authenticated (slave / framework). The behaviour on this > specific event (failed to init the authenticator) has not changed. I believe > we commented on this before and agreed to come up with a cleanup on > authentication result handling later, in a follow-up-patch. Do I remember > correctly here? > > Adam B wrote: > Let's create a separate JIRA so that authenticatees (or the owning > framework/slave) can know from the authentication response (error/failed) > whether to quit or retry.
https://issues.apache.org/jira/browse/MESOS-2482. Marking this as fixed for now. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review76090 ----------------------------------------------------------- On March 20, 2015, 10:21 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 10:21 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > include/mesos/authentication/authenticator.hpp f66217a > src/authentication/cram_md5/authenticator.hpp c6f465f > src/authentication/cram_md5/authenticator.cpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp b894386 > src/master/master.hpp 3c957ab > src/master/master.cpp dccd7c6 > src/tests/cram_md5_authentication_tests.cpp 92a89c5 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
