----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review78391 -----------------------------------------------------------
There is another nice aspect of requiring SlaveID in Reconcile and in Kill, we can make SlaveID in TaskStatus required. Are you planning to add a TODO for that? Will we be ever be able to make it required? include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32502/#comment127009> You can kill this now that we have a doc. include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32502/#comment127024> Should we make this a Reconcile::Task as opposed to a Reconcile::Status, now that it's no longer a TaskStatus? I'm also tempted to add a TODO for calling this 'Query' instead and allowing schedulers to query the master for additional things (other than tasks). src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127027> Shouldn't this come before you create the mesos object? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127028> Shouldn't this come before you create the mesos object? Otherwise seems like you may receive the REGISTERED event before you set up this expectation? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127031> newline here? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127032> newline here? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127030> newline here? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment127029> Do you want to check the reason? - Ben Mahler On March 31, 2015, 12:07 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32502/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:07 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Having a slave id will help us do better reconciliation. So added it to the > 'Reconcile' call. > > Also updated the master to receive the Reconcile call directly. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32502/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
