----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review80827 -----------------------------------------------------------
Ship it! include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32502/#comment130934> This still refers to 'statuses'? src/master/master.cpp <https://reviews.apache.org/r/32502/#comment130936> How about some newlines here? You could set the slave id last since it requires an 'if'. src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32502/#comment130938> Maybe we should test without this set? - Ben Mahler On April 20, 2015, 7:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32502/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 7:59 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Having a slave id will help us do better reconciliation. So added it to the > 'Reconcile' call. > > Also updated the master to receive the Reconcile call directly. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc > src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32502/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
