> On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > There is another nice aspect of requiring SlaveID in Reconcile and in Kill, > > we can make SlaveID in TaskStatus required. Are you planning to add a TODO > > for that? Will we be ever be able to make it required?
Added a TODO. The only way we can make it required though would be to give advance notice to frameworks (executors) to always set it and then make it required in a future version. > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, lines 241-244 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line241> > > > > Shouldn't this come before you create the mesos object? REGISTERED event can only be received after a REGISTER call is sent. Just creating the Mesos object doesn't cause any registration to happen. > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, lines 241-244 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line241> > > > > Shouldn't this come before you create the mesos object? Otherwise seems > > like you may receive the REGISTERED event before you set up this > > expectation? see above. > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 309 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line309> > > > > Do you want to check the reason? good idea. done. > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 279 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line279> > > > > newline here? done > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 281 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line281> > > > > newline here? done > On March 31, 2015, 9:49 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 298 > > <https://reviews.apache.org/r/32502/diff/2/?file=910153#file910153line298> > > > > newline here? done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review78391 ----------------------------------------------------------- On March 31, 2015, 12:07 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32502/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:07 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Having a slave id will help us do better reconciliation. So added it to the > 'Reconcile' call. > > Also updated the master to receive the Reconcile call directly. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32502/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
