----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/#review80321 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/33257/#comment130173> Kill this line. src/slave/slave.cpp <https://reviews.apache.org/r/33257/#comment130165> Remove this line. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130167> Could you add a comment and describe what this test does? src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130176> Move this down to when you need it. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130175> Move this down to when you actually need it. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130168> I am not sure this comment adds any value - we may just as well remove it, no? src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130174> Kill these. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130166> Could you add a comment and describe what this test does? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130178> Move this down to where you need it. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130177> Move this down to where you need it. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130179> Move this down to where you need it. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130180> Move this down to where you need it. - Till Toenshoff On April 16, 2015, 7:10 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33257/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 7:10 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, Jie > Yu, and Till Toenshoff. > > > Bugs: MESOS-2601 > https://issues.apache.org/jira/browse/MESOS-2601 > > > Repository: mesos > > > Description > ------- > > Fixed recover tasks only by the intiated containerizer. > Currently both mesos and docker containerizer recovers tasks that wasn't > started by themselves. > The proposed fix is to record the intended containerizer in the checkpointed > executorInfo, and reuse that information on recover to know if the > containerizer should recover or not. We are free to modify the executorInfo > since it's not being used to relaunch any task. > The external containerizer doesn't need to change since it is only recovering > containers that are returned by the containers script. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp f9fb07806e3b7d7d2afc1be3b8756eac23b32dcd > src/slave/containerizer/mesos/containerizer.cpp > e4136095fca55637864f495098189ab3ad8d8fe7 > src/slave/slave.cpp a0595f93ce4720f5b9926326d01210460ccb0667 > src/tests/containerizer_tests.cpp 5991aa628083dac7c5e8bf7ba297f4f9edeec05f > src/tests/docker_containerizer_tests.cpp > c772d4c836de18b0e87636cb42200356d24ec73d > > Diff: https://reviews.apache.org/r/33257/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
