----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/#review80813 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/33257/#comment130926> Although functionally doesn't break anything, the effect is that mesos containerizer will think it owns these executors as well and report it to monitoring, IMO it's another issue that we will need to fix in the mesos containerizer in another patch. src/slave/slave.cpp <https://reviews.apache.org/r/33257/#comment130925> Not sure what else we need in the future, sounds good I'll copy the whole containerinfo when it's there. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/33257/#comment130927> I can set it as well. - Timothy Chen On April 17, 2015, 7:07 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33257/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 7:07 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, Jie > Yu, and Till Toenshoff. > > > Bugs: MESOS-2601 > https://issues.apache.org/jira/browse/MESOS-2601 > > > Repository: mesos > > > Description > ------- > > Fixed recover tasks only by the intiated containerizer. > Currently both mesos and docker containerizer recovers tasks that wasn't > started by themselves. > The proposed fix is to record the intended containerizer in the checkpointed > executorInfo, and reuse that information on recover to know if the > containerizer should recover or not. We are free to modify the executorInfo > since it's not being used to relaunch any task. > The external containerizer doesn't need to change since it is only recovering > containers that are returned by the containers script. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 6893684e6d199a5d69fc8bba8e60c4acaae9c3c9 > src/slave/containerizer/docker.cpp f9fb07806e3b7d7d2afc1be3b8756eac23b32dcd > src/slave/containerizer/mesos/containerizer.cpp > e4136095fca55637864f495098189ab3ad8d8fe7 > src/slave/slave.cpp a0595f93ce4720f5b9926326d01210460ccb0667 > src/tests/containerizer_tests.cpp 5991aa628083dac7c5e8bf7ba297f4f9edeec05f > src/tests/docker_containerizer_tests.cpp > c772d4c836de18b0e87636cb42200356d24ec73d > > Diff: https://reviews.apache.org/r/33257/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
