----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review80485 -----------------------------------------------------------
This patch introduce some technical debt: There is currently no good way to synchronize between the test body and the hook code, so we wire a promise (owned by the test code). Let's capture this well by creating JIRA's, commenting the code and add it to the description of this review request, so it goes into the commit message. src/examples/test_hook_module.cpp <https://reviews.apache.org/r/29947/#comment130407> Let's add a lot of context here as to why we need to share this between the module and the test body :) src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment130410> Symbol doesn't describe if it is going to be a function or just a variable. I wonder if we can come up with a bit more precise name src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment130420> Can you expand on why you need to do this? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment130422> This is the part I hoped we could get around. Can you add a todo with the jira referring to the technical debt? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment130423> s/ / / - Niklas Nielsen On Jan. 27, 2015, 4:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:39 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > The task must be killed properly before shutting down the driver. > > > Diffs > ----- > > src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
