> On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/examples/test_hook_module.cpp, line 120 > > <https://reviews.apache.org/r/29947/diff/7/?file=837750#file837750line120> > > > > Why would this get called multiple times? > > Kapil Arya wrote: > If for example, someone writes a test case that installs all hooks but > verifies only a subset of them. However, this concern would be mitigated > once we use libprocess events.
Removed in the latest patch. > On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/tests/hook_tests.cpp, line 94 > > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line94> > > > > This whole promise lookup looks wrong to me. Is there any other way we > > can get the Promise/Future exposed through the module API? Maybe just add a > > "Future<something> executed()" or whatever? > > Kapil Arya wrote: > Should not be a concern (see above). Removed in the lates diff. > On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/tests/hook_tests.cpp, lines 302-305 > > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line302> > > > > Did you consider just sending an explicit ShutdownExecutorMessage from > > the slave to the executor? Then you can wait around for the hook to > > complete without worrying about the master/slave/framework shutting down in > > the meantime. I haven't considered the explicit message. I will try to find a prior example and adjust accordingly. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review71946 ----------------------------------------------------------- On April 21, 2015, 2:44 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 2:44 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > There is currently no good way to synchronize between the test body and the > hook code, so we wire a promise (owned by the test code). The technical debt > is covered by the following JIRA issue: > > https://issues.apache.org/jira/browse/MESOS-2641 > > > Diffs > ----- > > src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
