> On April 17, 2015, 1:56 p.m., Niklas Nielsen wrote: > > src/tests/hook_tests.cpp, line 71 > > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line71> > > > > Symbol doesn't describe if it is going to be a function or just a > > variable. I wonder if we can come up with a bit more precise name
The latest patch uses a function named "org_apache_mesos_TestHook_Initialize", which I think is quite explicit :-). > On April 17, 2015, 1:56 p.m., Niklas Nielsen wrote: > > src/tests/hook_tests.cpp, lines 109-111 > > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line109> > > > > Can you expand on why you need to do this? Added a comment. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review80485 ----------------------------------------------------------- On April 21, 2015, 2:44 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 2:44 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > There is currently no good way to synchronize between the test body and the > hook code, so we wire a promise (owned by the test code). The technical debt > is covered by the following JIRA issue: > > https://issues.apache.org/jira/browse/MESOS-2641 > > > Diffs > ----- > > src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
