> On April 13, 2015, 5:45 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 729 > > <https://reviews.apache.org/r/32975/diff/3/?file=925449#file925449line729> > > > > Why not use a random username here, like a UUID. Or, check if the user > > exist.
fixed as suggested using UUID for username > On April 13, 2015, 5:45 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 735 > > <https://reviews.apache.org/r/32975/diff/3/?file=925449#file925449line735> > > > > unused? removed > On April 13, 2015, 5:45 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 788 > > <https://reviews.apache.org/r/32975/diff/3/?file=925449#file925449line788> > > > > unused? removed. this was left from a cut/paste in another test that has a TODO associated with stdin/stdout redirect. > On April 13, 2015, 5:45 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 789 > > <https://reviews.apache.org/r/32975/diff/3/?file=925449#file925449line789> > > > > unused? removed - Jim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79902 ----------------------------------------------------------- On April 13, 2015, 4:55 p.m., Jim Klucar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32975/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 4:55 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1790 > https://issues.apache.org/jira/browse/MESOS-1790 > > > Repository: mesos > > > Description > ------- > > Added chown to CommandInfo.URI protocol buffer as an optional > boolean that defaults to true, the current chown behavior. > > The fetcher was updated to skip the os::chown operation if the chown > boolean is set to false. > > No documentation was updated. > > > Diffs > ----- > > include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 > src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b > src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 > src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e > > Diff: https://reviews.apache.org/r/32975/diff/ > > > Testing > ------- > > Unit testing this functionality is difficult because it would require that > the user running the test to have permission to chown a file to someone other > than themselves. I didn't want to add that as a requirement to build. I added > the new field to the existing test cases just to see that they populate. > > > Thanks, > > Jim Klucar > >
