Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/20#discussion_r29603480
--- Diff:
core/src/main/java/org/apache/metamodel/query/parser/FromItemParser.java ---
@@ -136,16 +169,17 @@ private FromItem parseJoinItem(final String
itemToken) {
// rightPart = "b.id"
final String rightPart = onClause.substring(indexOfEquals +
1).trim();
- leftOn[i] = findSelectItem(leftPart, leftSide, rightSide);
- rightOn[i] = findSelectItem(rightPart, leftSide, rightSide);
+ leftOn[i] = findSelectItem(leftPart, fromItems.toArray(new
FromItem[fromItems.size()]), rightSide);
+ rightOn[i] = findSelectItem(rightPart, fromItems.toArray(new
FromItem[fromItems.size()]), rightSide);
--- End diff --
Let's only create that array once and reuse it for both calls to
findSelectItem(...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
