Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/20#discussion_r29607596
--- Diff:
core/src/main/java/org/apache/metamodel/query/parser/FromItemParser.java ---
@@ -153,17 +183,23 @@ private SelectItem findSelectItem(String token,
FromItem leftSide, FromItem righ
if (result == null) {
// fail over and try with the from items available in the join
that
// is being built.
- final Query temporaryQuery = new Query().from(leftSide,
rightSide);
--- End diff --
What I meant was that here you could just pass in the whole set of from
items, instead of the two here. Then it's not more combinations, but fewer I
think. At least you would then not need the new for-loop below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
