Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/20#discussion_r29603750
--- Diff:
core/src/main/java/org/apache/metamodel/query/parser/FromItemParser.java ---
@@ -136,16 +169,17 @@ private FromItem parseJoinItem(final String
itemToken) {
// rightPart = "b.id"
final String rightPart = onClause.substring(indexOfEquals +
1).trim();
- leftOn[i] = findSelectItem(leftPart, leftSide, rightSide);
- rightOn[i] = findSelectItem(rightPart, leftSide, rightSide);
+ leftOn[i] = findSelectItem(leftPart, fromItems.toArray(new
FromItem[fromItems.size()]), rightSide);
+ rightOn[i] = findSelectItem(rightPart, fromItems.toArray(new
FromItem[fromItems.size()]), rightSide);
}
-
- final FromItem result = new FromItem(joinType, leftSide,
rightSide, leftOn, rightOn);
+
+ final FromItem leftItem = (leftFromItem != null) ? leftFromItem :
leftSide;
+ final FromItem result = new FromItem(joinType, leftItem,
rightSide, leftOn, rightOn);
result.setQuery(_query);
return result;
}
- private SelectItem findSelectItem(String token, FromItem leftSide,
FromItem rightSide) {
+ private SelectItem findSelectItem(String token, FromItem[] leftSides,
FromItem rightSide) {
--- End diff --
Actually, wouldn't it almost be better to just pass in the whole Set here
instead of an array + an instance of FromItem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
