Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101201
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java ---
@@ -209,13 +205,13 @@ protected void onSchemaCacheRefreshed() {
return null;
}
- private SpreadsheetReaderDelegate
getSpreadsheetReaderDelegate(Ref<InputStream> inputStream)
+ private SpreadsheetReaderDelegate getSpreadsheetReaderDelegate()
throws MetaModelException {
if (_spreadsheetReaderDelegate == null) {
synchronized (this) {
if (_spreadsheetReaderDelegate == null) {
try {
- if
(POIXMLDocument.hasOOXMLHeader(inputStream.get())) {
+ if
(POIXMLDocument.hasOOXMLHeader(getInputStream())) {
--- End diff --
Rewrite looks good, except I'm not sure I like the logger.error() when
still falling back. Either cancel with an error, or try to recover with a
warning.
(this may be the same as before, but Github's diff interface is terrible on
the mobile, so I can't see it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
